Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[data-plane] refresh ai-translation-text-rest #31637

Merged
merged 6 commits into from
Dec 20, 2024
Merged

[data-plane] refresh ai-translation-text-rest #31637

merged 6 commits into from
Dec 20, 2024

Conversation

kazrael2119
Copy link
Contributor

@kazrael2119 kazrael2119 commented Nov 5, 2024 •
edited
Loading

@kazrael2119 kazrael2119 mentioned this pull request Nov 5, 2024
Open
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

@azure-rest/ai-translation-text

qiaozha
qiaozha reviewed Nov 7, 2024
View reviewed changes
Copy link
Member

@qiaozha qiaozha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor issues

sdk/translation/ai-translation-text-rest/test/public/breakSentenceTest.spec.ts Outdated Show resolved Hide resolved
sdk/translation/ai-translation-text-rest/tsconfig.json Outdated Show resolved Hide resolved
@qiaozha qiaozha changed the title refresh ai-translation-text-rest [data-plane] refresh ai-translation-text-rest Dec 3, 2024
@qiaozha qiaozha marked this pull request as ready for review December 19, 2024 07:30
@qiaozha qiaozha requested review from bterlson, a team and xirzec as code owners December 19, 2024 07:30
@jeremymeng jeremymeng merged commit 7ab722d into Azure:main Dec 20, 2024
32 checks passed
@kazrael2119 kazrael2119 deleted the ai-translation-text-rest branch December 20, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiaozha qiaozha qiaozha approved these changes

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@xirzec xirzec Awaiting requested review from xirzec xirzec is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kazrael2119 @azure-sdk @qiaozha @jeremymeng