Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failed to run dev-tool admin migrate-package ... in Windows #32202

Closed
1 task done
wanlwanl opened this issue Dec 13, 2024 · 1 comment
Closed
1 task done

Failed to run dev-tool admin migrate-package ... in Windows #32202

wanlwanl opened this issue Dec 13, 2024 · 1 comment
Labels
dev-tool Issues related to the Azure SDK for JS dev-tool

Comments

@wanlwanl
Copy link
Member

  • Operating system: Windows
  • nodejs
    • version: : 23.4

Describe the bug

Failed to run dev-tool admin migrate-package ... in Windows
Got error spawn npm ENOENT

Workaround
Didn't add {shell: true} for spawn
I modify some files to workaround, check out: https://github.com/Azure/azure-sdk-for-js/pull/32201/files#diff-b5c6091a6b6c3d41963de6bcb4443000186b55d3c8f76469ed31037cb29134fd

To Reproduce
Same to: #32200

Expected behavior
Able to run the tool in Windows
@github-actions github-actions bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 13, 2024
@wanlwanl wanlwanl mentioned this issue Dec 13, 2024
Merged
@jeremymeng jeremymeng added the dev-tool Issues related to the Azure SDK for JS dev-tool label Dec 13, 2024
@github-actions github-actions bot removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 13, 2024
jeremymeng added a commit to jeremymeng/azure-sdk-for-js that referenced this issue Dec 13, 2024
@jeremymeng
[dev-tool] fix migrate-package issues on Windows
8086c1e 
Some CLI scripts (prettier, npm, for example) would report error on Windows when
they are invoked via `spawn()` without `shell: true` options. This PR fixes the
issue by applying the same workaround in PR Azure#29414.

Resolves issue Azure#32202
@jeremymeng jeremymeng mentioned this issue Dec 13, 2024
Merged
jeremymeng added a commit that referenced this issue Dec 13, 2024
@jeremymeng
[dev-tool] fix migrate-package issues on Windows (#32220)
2d2c913 
Some CLI scripts (prettier, npm, for example) would cause error on
Windows when they are invoked via `spawn()` without `shell: true`
options. This PR fixes the issue by applying the same workaround in PR
#29414.

Resolves issue #32202
@mpodwysocki
Copy link
Member

Fixed as per #32220

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dev-tool Issues related to the Azure SDK for JS dev-tool
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jeremymeng @mpodwysocki @wanlwanl