Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old state #234

Closed
wants to merge 6 commits into from
Closed

Old state #234

wants to merge 6 commits into from

Conversation

carlynlee
Copy link

Description

Fixes

  • Fixes #XX
  • Fixes #XX

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (internal implementation changes)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (no changes to the code)
  • CI change (changes to CI workflows, packages, templates, etc.)
  • Version changes (changes to the package or dependency versions)

Testing

N/A

Other Pull Request Checklist

Please confirm the PR meets the following requirements.

  • Code changes pass pre-commit (e.g., ruff, mypy, etc.) via pre-commit run --all-files.
  • Tests have been added to show the fix is effective or that the new feature works.
  • New and existing unit tests pass locally with the changes.
  • Docs have been updated and reviewed if relevant.

@Zilinghan
Copy link
Member

Hi @carlynlee, thank you for your PR. I wonder what are the purpose of this PR, thanks!

@Zilinghan Zilinghan closed this Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants