Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Support .netstandard2.1 #3424

Open
wants to merge 1 commit into
base: release/1.5.0
Choose a base branch
from

Conversation

gldeng
Copy link
Contributor

@gldeng gldeng commented Jun 26, 2023

No description provided.

@vizipi
Copy link

vizipi bot commented Jun 26, 2023

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code.
This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

Reviewers with knowledge related to these changes

Match % Person Commit Count Common Files
35.71 % 轩辕焮痕 1 15
16.67 % jason-hoopox 7 7
14.29 % ZhangXin 27 6
14.29 % loning 11 6
4.76 % Stephen01Zhang 2 2

Potential missing files from this Pull request

No commonly committed files found with a 40% threashold


Committed file ranks

(click to expand)
  • 56.95%[src/AElf.Types/Extensions/IMessageExtensions.cs]
  • 20.54%[src/AElf.Cryptography/IAElfAsymmetricCipherKeyPair.cs]
  • 73.65%[src/AElf.Types/Base58.cs]
  • 88.82%[src/AElf.Types/Extensions/ByteExtensions.cs]
  • 40.27%[src/AElf.Types/IHashProvider.cs]
  • 20.54%[...src/AElf.Cryptography/Exceptions/SignatureOperationExcept]
  • 91.51%[src/AElf.Cryptography/SecretSharing/SecretSharingHelper.cs]
  • 92.69%[src/AElf.Cryptography/CryptoHelper.cs]
  • 80.73%[src/AElf.Types/IBlockBase.cs]
  • 62.47%[src/AElf.Types/Helper/ChainHelper.cs]
  • @vizipi vizipi bot requested review from hzz780, jason-aelf, zhxymh and loning June 26, 2023 10:17
    @codecov
    Copy link

    codecov bot commented Jun 26, 2023

    Codecov Report

    Merging #3424 (d4d5b6b) into release/1.5.0 (ff547f2) will increase coverage by 0.23%.
    The diff coverage is 89.59%.

    Additional details and impacted files

    Impacted file tree graph

    @@                Coverage Diff                @@
    ##           release/1.5.0    #3424       /-   ##
    =================================================
      Coverage          90.60%   90.83%    0.23%     
    =================================================
      Files                653      653              
      Lines              24356    24906      550     
      Branches            2142     2301      159     
    =================================================
      Hits               22067    22623      556     
      Misses              2184     2178       -6     
      Partials             105      105              
    Impacted Files Coverage Δ
    src/AElf.Cryptography/ECDSA/ECParameters.cs 0.00% <0.00%> (ø)
    src/AElf.Types/Types/BigIntValue.cs 26.31% <29.26%> (ø)
    src/AElf.Cryptography/CryptoHelper.cs 83.17% <79.54%> (ø)
    src/AElf.Types/Types/Transaction.cs 91.30% <91.30%> (ø)
    src/AElf.Types/Types/Address.cs 95.94% <95.94%> (ø)
    src/AElf.Types/Extensions/ByteExtensions.cs 96.77% <96.29%> (ø)
    src/AElf.Types/Helper/ByteArrayHelper.cs 97.14% <97.05%> (ø)
    src/AElf.Types/Types/BinaryMerkleTree.cs 98.36% <98.11%> (ø)
    src/AElf.Types/Helper/SerializationHelper.cs 98.70% <98.50%> (ø)
    src/AElf.Cryptography/ECDSA/ECKeyPair.cs 100.00% <100.00%> (ø)
    ... and 24 more

    ... and 4 files with indirect coverage changes

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant